Fix double mention of DeliveryComplete#6226
Merged
Merged
Conversation
I should have noticed this when quickly doing Textualize#6225. The documentation for `name` in `Driver.deliver_binary` calls out `DeliveryComplete` twice; I would imagine this is really meant to be a call out to `DeliveryComplete` and `DeliveryFailed`.
Contributor
Author
|
Given this was a docstring tweak... looks like the fail might be a flakey test? |
Contributor
This flaky test is fixed by #6223 when Will does his next round of reviewing PRs. |
willmcgugan
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I should have noticed this when quickly doing #6225. The documentation for
nameinDriver.deliver_binarycalls outDeliveryCompletetwice; I would imagine this is really meant to be a call out toDeliveryCompleteandDeliveryFailed.